🌊 Волна 12: frontend утечки + достижения (7 багов)

Утечки ObjectURL:
- URL_LEAK_FLASHCARDS: audioUrlRef + revoke (FlashcardsPage.tsx)
- URL_LEAK_PRONUNCIATION: audioUrlRef + revoke (PronunciationPage.tsx)
- URL_LEAK_TYPING: audioUrlRef + revoke (TypingPage.tsx)
- URL_LEAK_TESTVIEW: audioUrlRef + revoke (TestViewPage.tsx)

UI:
- ALERT_IN_TELEGRAM_MINIAPP: toast вместо alert() в TestViewPage (3 места)

Достижения:
- achievements_queue_overwrite_loses_new_items: функциональный update очереди (useAchievements.ts)
- achievements_reset_does_not_clear_timeout: clearTimeout в reset (useAchievements.ts)

Аудит v2: Issue #4, frontend 7/14 задач
This commit is contained in:
2026-09-24 12:44:32 +03:00
parent f041d46418
commit f878411dce
5 changed files with 187 additions and 30 deletions
+24
View File
@@ -29,6 +29,8 @@ const PronunciationPage: React.FC = () => {
const [isPlaying, setIsPlaying] = useState(false);
const [showRules, setShowRules] = useState(false);
const audioRef = useRef<HTMLAudioElement | null>(null);
// 🔧 ФИКС (24.09.2026): URL_LEAK_PRONUNCIATION — храним URL для revoke.
const audioUrlRef = useRef<string | null>(null);
const isMountedRef = useRef(true);
const rulesShownRef = useRef(false);
const trackedRef = useRef(false);
@@ -57,6 +59,12 @@ const PronunciationPage: React.FC = () => {
audioRef.current = null;
}
// 🔧 ФИКС (24.09.2026): URL_LEAK_PRONUNCIATION — освобождаем предыдущий URL
if (audioUrlRef.current) {
try { URL.revokeObjectURL(audioUrlRef.current); } catch { /* ignore */ }
audioUrlRef.current = null;
}
// Останавливаем Web Speech API, если он что-то говорит
if ('speechSynthesis' in window) {
window.speechSynthesis.cancel();
@@ -68,15 +76,26 @@ const PronunciationPage: React.FC = () => {
// Пробуем Edge TTS через бэкенд
const audioBlob = await getTTS(word, 'male');
const audioUrl = URL.createObjectURL(audioBlob);
audioUrlRef.current = audioUrl; // 🔧 сохраняем для revoke
const audio = new Audio(audioUrl);
audioRef.current = audio;
audio.onended = () => {
if (isMountedRef.current) setIsPlaying(false);
// 🔧 ФИКС (24.09.2026): освобождаем URL
if (audioUrlRef.current === audioUrl) {
try { URL.revokeObjectURL(audioUrl); } catch { /* ignore */ }
audioUrlRef.current = null;
}
};
audio.onerror = () => {
// 🔧 Освобождаем URL перед fallback
if (audioUrlRef.current === audioUrl) {
try { URL.revokeObjectURL(audioUrl); } catch { /* ignore */ }
audioUrlRef.current = null;
}
// Edge TTS не сработал — пробуем Web Speech API
playWebSpeech(word);
};
@@ -169,6 +188,11 @@ const PronunciationPage: React.FC = () => {
audioRef.current.pause();
audioRef.current = null;
}
// 🔧 ФИКС (24.09.2026): URL_LEAK_PRONUNCIATION — освобождаем URL при unmount
if (audioUrlRef.current) {
try { URL.revokeObjectURL(audioUrlRef.current); } catch { /* ignore */ }
audioUrlRef.current = null;
}
// Останавливаем Web Speech API при уходе со страницы
if ('speechSynthesis' in window) {
window.speechSynthesis.cancel();