🌊 Волна 17: backend #8 — баги + N+1 (16 багов)
Продуктовые: - hint_consumed_before_word_check: сначала проверка слов, потом инкремент (hints.py) - hint_fake_first_cell: 404 вместо [0,0] (hints.py) - leaderboard_rank_wrong_for_uncached_user: корректный rank (leaderboard.py) - teacher_ai_explanation_empty_on_failure: fallback-текст (teacher.py) Данные: - duplicate_delete_keeps_wrong_row: оставляем лучшую строку (database.py) Security: - fastapi_docs_exposed: /docs скрыт в проде (main.py) - cf_ip_check_per_request: предкомпиляция CF_IPS (main.py) N+1: - admin_content_lesson_levels_n_plus_1: 3 GROUP BY (admin_content.py) - admin_content_lesson_topics_n_plus_1: 2 GROUP BY (admin_content.py) - admin_content_get_lesson_n_plus_1: ANY + группировка (admin_content.py) - teacher_progress_n_plus_1: 2 GROUP BY (teacher.py) - teacher_diagnostic_test_n_plus_1: ANY + группировка (teacher.py) - orchestrator_n_plus_1_options: ANY + группировка (orchestrator.py) Качество: - cleanup_task_leak_on_startup_failure: cleanup после init (main.py) - unused_first_name: удалена мёртвая переменная (auth.py) Пропущено осознанно: - initdata_in_query_param (fallback deleteFeedPost) - init_db_slow_startup (Alembic, отдельная задача) Аудит v5: Issue #8, backend 16/17 задач
This commit is contained in:
+47
-18
@@ -169,17 +169,28 @@ async def get_lesson_by_id(conn, lesson_id: str) -> Optional[Dict[str, Any]]:
|
||||
WHERE lesson_id = $1 AND is_test_question = FALSE
|
||||
ORDER BY id
|
||||
""", lesson_id)
|
||||
|
||||
|
||||
# 🔧 ФИКС (25.09.2026): orchestrator_n_plus_1_options —
|
||||
# один запрос ANY + группировка в Python.
|
||||
question_ids = [q["question_id"] for q in questions]
|
||||
all_options = []
|
||||
if question_ids:
|
||||
all_options = await conn.fetch("""
|
||||
SELECT * FROM question_options
|
||||
WHERE question_id = ANY($1::text[])
|
||||
""", question_ids)
|
||||
|
||||
options_by_q: dict = {}
|
||||
for o in all_options:
|
||||
options_by_q.setdefault(o["question_id"], []).append(dict(o))
|
||||
|
||||
questions_data = []
|
||||
for q in questions:
|
||||
options = await conn.fetch("""
|
||||
SELECT * FROM question_options WHERE question_id = $1
|
||||
""", q["question_id"])
|
||||
questions_data.append({
|
||||
"question": dict(q),
|
||||
"options": [dict(o) for o in options],
|
||||
"options": options_by_q.get(q["question_id"], []),
|
||||
})
|
||||
|
||||
|
||||
return {
|
||||
"lesson": dict(lesson),
|
||||
"examples": [dict(e) for e in examples],
|
||||
@@ -195,17 +206,26 @@ async def get_lesson_questions(conn, lesson_id: str) -> list:
|
||||
WHERE lesson_id = $1 AND is_test_question = FALSE
|
||||
ORDER BY id
|
||||
""", lesson_id)
|
||||
|
||||
|
||||
question_ids = [q["question_id"] for q in questions]
|
||||
all_options = []
|
||||
if question_ids:
|
||||
all_options = await conn.fetch("""
|
||||
SELECT * FROM question_options
|
||||
WHERE question_id = ANY($1::text[])
|
||||
""", question_ids)
|
||||
|
||||
options_by_q: dict = {}
|
||||
for o in all_options:
|
||||
options_by_q.setdefault(o["question_id"], []).append(dict(o))
|
||||
|
||||
questions_data = []
|
||||
for q in questions:
|
||||
options = await conn.fetch("""
|
||||
SELECT * FROM question_options WHERE question_id = $1
|
||||
""", q["question_id"])
|
||||
questions_data.append({
|
||||
"question": dict(q),
|
||||
"options": [dict(o) for o in options],
|
||||
"options": options_by_q.get(q["question_id"], []),
|
||||
})
|
||||
|
||||
|
||||
return questions_data
|
||||
|
||||
|
||||
@@ -217,17 +237,26 @@ async def get_test_questions(conn, topic_id: str) -> list:
|
||||
WHERE topic_id = $1 AND is_test_question = TRUE
|
||||
ORDER BY test_order
|
||||
""", topic_id)
|
||||
|
||||
|
||||
question_ids = [q["question_id"] for q in questions]
|
||||
all_options = []
|
||||
if question_ids:
|
||||
all_options = await conn.fetch("""
|
||||
SELECT * FROM question_options
|
||||
WHERE question_id = ANY($1::text[])
|
||||
""", question_ids)
|
||||
|
||||
options_by_q: dict = {}
|
||||
for o in all_options:
|
||||
options_by_q.setdefault(o["question_id"], []).append(dict(o))
|
||||
|
||||
questions_data = []
|
||||
for q in questions:
|
||||
options = await conn.fetch("""
|
||||
SELECT * FROM question_options WHERE question_id = $1
|
||||
""", q["question_id"])
|
||||
questions_data.append({
|
||||
"question": dict(q),
|
||||
"options": [dict(o) for o in options],
|
||||
"options": options_by_q.get(q["question_id"], []),
|
||||
})
|
||||
|
||||
|
||||
return questions_data
|
||||
|
||||
|
||||
|
||||
Reference in New Issue
Block a user